job-builder: add amazon-ecr-credential-helper to the job builder #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rootless job builder is based on an image that does not contain the amazon-ecr-credential-helper utility. This utility is necessary to authenticate against ECR when pushing data job images. This commit adds the amazon-ecr-credential-helper utility to the job-builder image by pulling it and building it locally from source. Maybe there is a better way of provisioning it but I could not find it out. Testing done: manually build and push a job-builder image with the change, then create a k8s job with this image and run it to verify that it manages to successfully push data job images to ECR. Signed-off-by: Tsvetomir Palashki <[email protected]>
|
LGTM |
|
Please increment the builder version. |
Signed-off-by: Tsvetomir Palashki <[email protected]>
mivanov1988
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rootless job builder is based on an image that does not contain
the amazon-ecr-credential-helper utility. This utility is necessary
to authenticate against ECR when pushing data job images.
This commit adds the amazon-ecr-credential-helper utility to the job-builder
image by pulling it and building it locally from source. Maybe there is
a better way of provisioning it but I could not find it out.
Testing done: manually build and push a job-builder image with the change,
then create a k8s job with this image and run it to verify that it manages
to successfully push data job images to ECR.
Signed-off-by: Tsvetomir Palashki [email protected]